Skip to content

MQE-659: [ALLURE] Include the test "stepKey" in the MFTF Allure Report #354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

MQE-659: [ALLURE] Include the test "stepKey" in the MFTF Allure Report #354

wants to merge 3 commits into from

Conversation

jilu1
Copy link
Contributor

@jilu1 jilu1 commented May 23, 2019

Description

Fixed Issues (if relevant)

  1. magento/magento2-functional-testing-framework#<issue_number>: Issue title
  2. ...

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@coveralls
Copy link

coveralls commented May 23, 2019 •
edited
Loading

Coverage Status

Coverage increased (+1.6%) to 55.987% when pulling a2884ae on MQE-659 into e11a5d0 on develop.

@okolesnyk okolesnyk self-requested a review May 29, 2019 21:35
@KevinBKozan
Copy link
Contributor

@jilu1 I'm not sure that the StepKeyReader class is 100% necessary; in the stepBefore hook, you can get access to the step's line number via $stepEvent->getStep(). That way we could do something really simple:

  • Keep read file in memory (in testBefore or something)
  • In stepBefore hook, read line from file in memory and strip out the //stepKey: <key>
  • Append to step name there

Since we could strip out the line itself we don't have to worry about parsing the file at all, thus eliminating the need for the reader class. Let me know if the suggestion makes sense, I feel pretty strongly in keeping code additions as trim as possible!

@KevinBKozan KevinBKozan self-requested a review June 5, 2019 14:09
@okolesnyk
Copy link
Member

In order to simplify fixing and code review I created my own edition of stepKey implementation and created new PR #359
This one will close to avoid confusion.

@okolesnyk okolesnyk closed this Jun 5, 2019
@tomreece tomreece deleted the MQE-659 branch July 27, 2020 14:07
magento-devops-reposync-svc pushed a commit that referenced this pull request Dec 5, 2023
@jilu1
Merge pull request #354 from magento-commerce/ACQE-5855
0654ac6 
ACQE-5855: Change command <magentoCLI> to maintain CLI output and onl…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@okolesnyk okolesnyk Awaiting requested review from okolesnyk

@KevinBKozan KevinBKozan Awaiting requested review from KevinBKozan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jilu1 @coveralls @KevinBKozan @okolesnyk